tools/telemetry/telemetry/internal/story_runner.py - Issue 1250123002: Fixed bug in story_runner's has_existing_exception.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/story_runner.py

Issue 1250123002: Fixed bug in story_runner's has_existing_exception. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/internal/story_runner.py

diff --git a/tools/telemetry/telemetry/internal/story_runner.py b/tools/telemetry/telemetry/internal/story_runner.py

index 9d9cbc1f374cc964b2d2d3b8ec4e467905590f66..9f8df9450d3bc5deed2a091c222fcc392306aacf 100644

--- a/tools/telemetry/telemetry/internal/story_runner.py

+++ b/tools/telemetry/telemetry/internal/story_runner.py

@@ -97,7 +97,7 @@ def _RunStoryAndProcessErrorIfNeeded(story, results, state, test):

story, sys.exc_info(), 'Unhandlable exception raised.'))

raise

finally:

- has_existing_exception = sys.exc_info() is not None

+ has_existing_exception = (sys.exc_info() != (None, None, None))

try:

state.DidRunStory(results)

# if state.DidRunStory raises exception, things are messed up badly and we

« no previous file with comments | « no previous file | no next file » | no next file with comments »