Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 1250003005: Fix ADB path passing to GDB in devtools (Closed)

Created:
5 years, 5 months ago by etiennej
Modified:
5 years, 5 months ago
Reviewers:
ppi
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M mojo/devtools/common/debugger View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
etiennej
5 years, 5 months ago (2015-07-23 00:27:53 UTC) #1
ppi
lgtm
5 years, 5 months ago (2015-07-23 01:56:56 UTC) #2
etiennej
5 years, 5 months ago (2015-07-23 16:28:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
355807f3fedd5f04b4aa48faf2aa14194bd40e32 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698