mojo/devtools/common/debugger - Issue 1250003005: Fix ADB path passing to GDB in devtools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/devtools/common/debugger

Issue 1250003005: Fix ADB path passing to GDB in devtools (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/devtools/common/debugger

diff --git a/mojo/devtools/common/debugger b/mojo/devtools/common/debugger

index cc2b0fe9b24a208d7defe8002dfe2b466e43920a..a07c6095d6a9285b2ac12f24d31302301af08b0a 100755

--- a/mojo/devtools/common/debugger

+++ b/mojo/devtools/common/debugger

@@ -222,6 +222,8 @@ def _gdb_attach(args):

debug_session_arguments["package_name"] = args.package_name

else:

debug_session_arguments["package_name"] = _DEFAULT_PACKAGE_NAME

+ if args.adb_path:

+ debug_session_arguments['adb'] = args.adb_path

if args.pyelftools_dir:

debug_session_arguments["pyelftools_dir"] = args.pyelftools_dir

else:

« no previous file with comments | « no previous file | no next file » | no next file with comments »