Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1249863004: Remove most error code from luci/gae (Closed)

Created:
5 years, 5 months ago by iannucci
Modified:
5 years, 5 months ago
Reviewers:
dnj, Vadim Sh., estaab
CC:
chromium-reviews
Base URL:
https://github.com/luci/gae.git@simplify_rds
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rename #

Patch Set 3 : get rid of goofy lerrs imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -282 lines) Patch
M impl/memory/raw_datastore_data.go View 1 2 12 chunks +15 lines, -16 lines 0 comments Download
M impl/memory/taskqueue.go View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M impl/prod/memcache.go View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M impl/prod/raw_datastore.go View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M impl/prod/taskqueue.go View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M service/rawdatastore/datastore_impl.go View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M upstream_errors.go View 1 1 chunk +0 lines, -110 lines 0 comments Download
M upstream_errors_test.go View 1 1 chunk +0 lines, -137 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 3 (0 generated)
iannucci
5 years, 5 months ago (2015-07-22 08:58:05 UTC) #1
dnj
lgtm
5 years, 5 months ago (2015-07-22 18:35:17 UTC) #2
iannucci
5 years, 5 months ago (2015-07-23 05:57:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
79652dc1ee469bd0d04dcee0ba531c28fc6f6ac8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698