Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1247283003: Improve docs (Closed)

Created:
5 years, 5 months ago by iannucci
Modified:
5 years, 5 months ago
Reviewers:
dnj, Vadim Sh., estaab
CC:
chromium-reviews
Base URL:
https://github.com/luci/gae.git@reduce_size
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve docs Simplify godoc by making some functions methods Rename 'filters' to 'filter' to be more consistent with 'impl' and 'service'. R=estaab@chromium.org, dnj@chromium.org, vadimsh@chromium.org BUG= Committed: https://github.com/luci/gae/commit/70dbe44f4d572b0d139949b252e4bfb0be95f8c1

Patch Set 1 #

Patch Set 2 : Improve dummy doc presentation #

Patch Set 3 : rebase #

Total comments: 6

Patch Set 4 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -1223 lines) Patch
M doc.go View 1 2 3 3 chunks +136 lines, -31 lines 0 comments Download
A + filter/count/count.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + filter/count/count_test.go View 1 chunk +1 line, -1 line 0 comments Download
A + filter/count/gi.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + filter/count/mc.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + filter/count/rds.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + filter/count/tq.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + filter/featureBreaker/featurebreaker.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + filter/featureBreaker/featurebreaker_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + filter/featureBreaker/gi.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + filter/featureBreaker/mc.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + filter/featureBreaker/rds.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + filter/featureBreaker/tq.go View 0 chunks +-1 lines, --1 lines 0 comments Download
D filters/count/count.go View 1 chunk +0 lines, -37 lines 0 comments Download
D filters/count/count_test.go View 1 chunk +0 lines, -149 lines 0 comments Download
D filters/count/gi.go View 1 chunk +0 lines, -137 lines 0 comments Download
D filters/count/mc.go View 1 chunk +0 lines, -93 lines 0 comments Download
D filters/count/rds.go View 1 chunk +0 lines, -104 lines 0 comments Download
D filters/count/tq.go View 1 chunk +0 lines, -81 lines 0 comments Download
D filters/featureBreaker/featurebreaker.go View 1 chunk +0 lines, -117 lines 0 comments Download
D filters/featureBreaker/featurebreaker_test.go View 1 chunk +0 lines, -61 lines 0 comments Download
D filters/featureBreaker/gi.go View 1 chunk +0 lines, -75 lines 0 comments Download
D filters/featureBreaker/mc.go View 1 chunk +0 lines, -101 lines 0 comments Download
D filters/featureBreaker/rds.go View 1 chunk +0 lines, -95 lines 0 comments Download
D filters/featureBreaker/tq.go View 1 chunk +0 lines, -91 lines 0 comments Download
M impl/dummy/doc.go View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M impl/memory/plist.go View 1 chunk +1 line, -1 line 0 comments Download
M impl/memory/raw_datastore_data.go View 3 chunks +9 lines, -5 lines 0 comments Download
M impl/prod/context.go View 2 chunks +20 lines, -1 line 0 comments Download
M service/info/context.go View 2 chunks +3 lines, -3 lines 0 comments Download
M service/memcache/context.go View 2 chunks +3 lines, -3 lines 0 comments Download
M service/rawdatastore/context.go View 2 chunks +3 lines, -3 lines 0 comments Download
M service/rawdatastore/errors.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M service/rawdatastore/properties.go View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M service/rawdatastore/serialize.go View 1 2 11 chunks +22 lines, -22 lines 0 comments Download
M service/rawdatastore/serialize_test.go View 3 chunks +21 lines, -15 lines 0 comments Download
M service/taskqueue/context.go View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
iannucci
5 years, 5 months ago (2015-07-22 08:46:18 UTC) #1
iannucci
On 2015/07/22 08:46:18, iannucci wrote: PTAL, this one is shorter than it looks :)
5 years, 5 months ago (2015-07-23 01:19:03 UTC) #2
estaab
LGTM, a few minor edit suggestions https://codereview.chromium.org/1247283003/diff/40001/doc.go File doc.go (right): https://codereview.chromium.org/1247283003/diff/40001/doc.go#newcode32 doc.go:32: // Package Organiaztion ...
5 years, 5 months ago (2015-07-23 04:43:11 UTC) #3
iannucci
Committed patchset #4 (id:60001) manually as 70dbe44f4d572b0d139949b252e4bfb0be95f8c1 (presubmit successful).
5 years, 5 months ago (2015-07-23 05:55:06 UTC) #4
iannucci
5 years, 5 months ago (2015-07-23 05:55:10 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1247283003/diff/40001/doc.go
File doc.go (right):

https://codereview.chromium.org/1247283003/diff/40001/doc.go#newcode32
doc.go:32: // Package Organiaztion
On 2015/07/23 04:43:11, estaab wrote:
> Organization

Done.

https://codereview.chromium.org/1247283003/diff/40001/doc.go#newcode59
doc.go:59: //   func inner_handler(c context.Context, w http.ResponseWriter) {
On 2015/07/23 04:43:11, estaab wrote:
> innerHandler

Done.

https://codereview.chromium.org/1247283003/diff/40001/impl/dummy/doc.go
File impl/dummy/doc.go (right):

https://codereview.chromium.org/1247283003/diff/40001/impl/dummy/doc.go#newcode5
impl/dummy/doc.go:5: // Package dummy comtains panicing dummy implementations of
all service
On 2015/07/23 04:43:11, estaab wrote:
> panicking

Done.

Powered by Google App Engine
This is Rietveld 408576698