Issue 1249723002: Revert "Preliminary support for Windows manifests in the GN build."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1249723002: Revert "Preliminary support for Windows manifests in the GN build." (Closed)

Created:
5 years, 5 months ago by Nico

Modified:
5 years, 5 months ago

Reviewers:
brettw

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, chromoting-reviews_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "Preliminary support for Windows manifests in the GN build." This reverts https://codereview.chromium.org/1240893004/ , it broke building remoting in the gyp build (see comment on the review). TBR=brettw@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/13e350d3f0ff78bd0e6b96c83ffbd428d695acac

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -230 lines)			Patch
D	build/config/win/manifest.gni	View	1 chunk	+0 lines, -182 lines	0 comments	Download
D	build/win/BUILD.gn	View	1 chunk	+0 lines, -16 lines	0 comments	Download
D	build/win/as_invoker.manifest	View	1 chunk	+0 lines, -9 lines	0 comments	Download
D	build/win/common_controls.manifest	View	1 chunk	+0 lines, -8 lines	0 comments	Download
A +	cloud_print/service/win/common-controls.manifest	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	cloud_print/service/win/service.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/shell/BUILD.gn	View	3 chunks	+1 line, -4 lines	0 comments	Download
A +	remoting/host/win/common-controls.manifest	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	remoting/remoting_host_win.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	testing/test.gni	View	1 chunk	+6 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

on the main waterfall too: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28dbg%29/builds/10839

5 years, 5 months ago (2015-07-21 17:01:17 UTC) #2

Nico

5 years, 5 months ago (2015-07-21 17:03:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
13e350d3f0ff78bd0e6b96c83ffbd428d695acac (tree was closed).

Expand Messages | Collapse Messages