test/cctest/test-api.cc - Issue 1249703005: Fix a -Wsign-compare error under GCC 4.9.2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-api.cc

Issue 1249703005: Fix a -Wsign-compare error under GCC 4.9.2. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-api.cc

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc

index 44d29d103745679535e0eb21ab506bca2ca49bfa..df32722e634e201921c7fbb439c66958ac917d5c 100644

--- a/test/cctest/test-api.cc

+++ b/test/cctest/test-api.cc

@@ -21029,7 +21029,7 @@ TEST(StreamingWithDebuggingEnabledLate) {

Maybe<uint32_t> result =

script->Run(env.local()).ToLocalChecked()->Uint32Value(env.local());

- CHECK_EQ(3, result.FromMaybe(0));

+ CHECK_EQ(3U, result.FromMaybe(0));

delete[] full_source;

« no previous file with comments | « no previous file | no next file » | no next file with comments »