Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Side by Side Diff: test/cctest/test-api.cc

Issue 1249703005: Fix a -Wsign-compare error under GCC 4.9.2. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 21011 matching lines...) Expand 10 before | Expand all | Expand 10 after
21022 v8::ScriptOrigin origin(v8_str("http://foo.com")); 21022 v8::ScriptOrigin origin(v8_str("http://foo.com"));
21023 char* full_source = TestSourceStream::FullSourceString(chunks); 21023 char* full_source = TestSourceStream::FullSourceString(chunks);
21024 21024
21025 EnableDebugger(); 21025 EnableDebugger();
21026 21026
21027 v8::Handle<Script> script = v8::ScriptCompiler::Compile( 21027 v8::Handle<Script> script = v8::ScriptCompiler::Compile(
21028 isolate, &source, v8_str(full_source), origin); 21028 isolate, &source, v8_str(full_source), origin);
21029 21029
21030 Maybe<uint32_t> result = 21030 Maybe<uint32_t> result =
21031 script->Run(env.local()).ToLocalChecked()->Uint32Value(env.local()); 21031 script->Run(env.local()).ToLocalChecked()->Uint32Value(env.local());
21032 CHECK_EQ(3, result.FromMaybe(0)); 21032 CHECK_EQ(3U, result.FromMaybe(0));
21033 21033
21034 delete[] full_source; 21034 delete[] full_source;
21035 21035
21036 DisableDebugger(); 21036 DisableDebugger();
21037 } 21037 }
21038 21038
21039 21039
21040 TEST(StreamingScriptWithInvalidUtf8) { 21040 TEST(StreamingScriptWithInvalidUtf8) {
21041 // Regression test for a crash: test that invalid UTF-8 bytes in the end of a 21041 // Regression test for a crash: test that invalid UTF-8 bytes in the end of a
21042 // chunk don't produce a crash. 21042 // chunk don't produce a crash.
(...skipping 884 matching lines...) Expand 10 before | Expand all | Expand 10 after
21927 21927
21928 v8::TryCatch try_catch(CcTest::isolate()); 21928 v8::TryCatch try_catch(CcTest::isolate());
21929 timeout_thread.Start(); 21929 timeout_thread.Start();
21930 21930
21931 CompileRun( 21931 CompileRun(
21932 "var ab = new SharedArrayBuffer(4);" 21932 "var ab = new SharedArrayBuffer(4);"
21933 "var i32a = new Int32Array(ab);" 21933 "var i32a = new Int32Array(ab);"
21934 "Atomics.futexWait(i32a, 0, 0);"); 21934 "Atomics.futexWait(i32a, 0, 0);");
21935 CHECK(try_catch.HasTerminated()); 21935 CHECK(try_catch.HasTerminated());
21936 } 21936 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698