Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 1249703005: Fix a -Wsign-compare error under GCC 4.9.2. (Closed)

Created:
5 years, 5 months ago by paul.l...
Modified:
5 years, 5 months ago
Reviewers:
Yang, Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix a -Wsign-compare error under GCC 4.9.2. BUG= Committed: https://crrev.com/0eacd754cc11d6f658703b5240af88a6b14b5d2d Cr-Commit-Position: refs/heads/master@{#29795}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
paul.l...
PTAL. If this looks ok, please commit it as well (I won't be back online ...
5 years, 5 months ago (2015-07-23 04:48:24 UTC) #2
Yang
lgtm
5 years, 5 months ago (2015-07-23 06:00:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249703005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1249703005/1
5 years, 5 months ago (2015-07-23 06:00:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 06:27:10 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 06:27:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0eacd754cc11d6f658703b5240af88a6b14b5d2d
Cr-Commit-Position: refs/heads/master@{#29795}

Powered by Google App Engine
This is Rietveld 408576698