Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1249663002: rename BitmapTextBlob and move it to its own file (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

rename BitmapTextBlob and move it to its own file BUG=skia: Committed: https://skia.googlesource.com/skia/+/374b2f7cea8b1117f0dd17cdecd2b3ec85b141d4

Patch Set 1 #

Total comments: 5

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -282 lines) Patch
M gyp/gpu.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A src/gpu/GrAtlasTextBlob.h View 1 1 chunk +216 lines, -0 lines 0 comments Download
M src/gpu/GrAtlasTextContext.h View 6 chunks +22 lines, -223 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 29 chunks +34 lines, -34 lines 0 comments Download
M src/gpu/GrTextBlobCache.h View 7 chunks +13 lines, -15 lines 0 comments Download
M src/gpu/GrTextBlobCache.cpp View 2 chunks +10 lines, -10 lines 0 comments Download

Dependent Patchsets:

Issue 1250693002 Patch 1
Issue 1250693002 Patch 20001
Issue 1250693002 Patch 40001
Issue 1250693002 Patch 60001

Messages

Total messages: 7 (3 generated)
joshualitt
ptal
5 years, 5 months ago (2015-07-21 14:32:50 UTC) #2
robertphillips
lgtm + nits & questions https://codereview.chromium.org/1249663002/diff/1/src/gpu/GrAtlasTextBlob.h File src/gpu/GrAtlasTextBlob.h (right): https://codereview.chromium.org/1249663002/diff/1/src/gpu/GrAtlasTextBlob.h#newcode11 src/gpu/GrAtlasTextBlob.h:11: #include "GrBatchAtlas.h" Need GrBatchFontCache.h ...
5 years, 5 months ago (2015-07-21 14:49:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249663002/20001
5 years, 5 months ago (2015-07-21 14:57:23 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 15:05:06 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/374b2f7cea8b1117f0dd17cdecd2b3ec85b141d4

Powered by Google App Engine
This is Rietveld 408576698