src/effects/SkColorCubeFilter.cpp - Issue 1249543003: Creating functions for uploading a mipmapped texture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkColorCubeFilter.cpp

Issue 1249543003: Creating functions for uploading a mipmapped texture. (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: Removing the concept of a dirty mipmap. It is expected that the texture upload provides the mipmaps. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkColorCubeFilter.cpp

diff --git a/src/effects/SkColorCubeFilter.cpp b/src/effects/SkColorCubeFilter.cpp

index c5d4fc5a35d0e910fc4d2bdee8167e4fb1a4a0b4..2323ee89899f3bf465e987d68d952254f00c2898 100644

--- a/src/effects/SkColorCubeFilter.cpp

+++ b/src/effects/SkColorCubeFilter.cpp

@@ -316,6 +316,7 @@ bool SkColorCubeFilter::asFragmentProcessors(GrContext* context, GrProcessorData

desc.fWidth = fCache.cubeDimension();

desc.fHeight = fCache.cubeDimension() * fCache.cubeDimension();

desc.fConfig = kRGBA_8888_GrPixelConfig;

+ desc.fIsMipMapped = false;

SkAutoTUnref<GrTexture> textureCube(

context->textureProvider()->findAndRefTextureByUniqueKey(key));