Issue 124943004: Prepare removal of ObjectTemplate::New without Isolate parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 124943004: Prepare removal of ObjectTemplate::New without Isolate parameter. (Closed)

Created:
6 years, 11 months ago by Sven Panne

Modified:
6 years, 11 months ago

Reviewers:
ulan

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Prepare removal of ObjectTemplate::New without Isolate parameter. LOG=y BUG=324225 R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18478

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+504 lines, -372 lines)			Patch
M	samples/lineprocessor.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	samples/process.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	samples/shell.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/api.cc	View	1	2 chunks	+7 lines, -5 lines	0 comments	Download
M	src/d8.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/i18n.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	test/cctest/test-accessors.cc	View		13 chunks	+43 lines, -35 lines	0 comments	Download
M	test/cctest/test-api.cc	View		149 chunks	+369 lines, -261 lines	0 comments	Download
M	test/cctest/test-assembler-ia32.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	test/cctest/test-assembler-x64.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	test/cctest/test-debug.cc	View		8 chunks	+60 lines, -52 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	test/cctest/test-object-observe.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-platform.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	test/cctest/test-thread-termination.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/lexer-shell.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

6 years, 11 months ago (2014-01-08 06:53:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r18478 (presubmit successful).