src/i18n.cc - Issue 124943004: Prepare removal of ObjectTemplate::New without Isolate parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/i18n.cc

Issue 124943004: Prepare removal of ObjectTemplate::New without Isolate parameter. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Do not remove ObjectTemplate::New() yet. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/i18n.cc

diff --git a/src/i18n.cc b/src/i18n.cc

index f340cc0bcf1e9524584b221186c9604a7fe6ea6d..5c97c6b8eef358293e5b2d25975e4295280b7c26 100644

--- a/src/i18n.cc

+++ b/src/i18n.cc

@@ -257,7 +257,8 @@ Handle<ObjectTemplateInfo> GetEternal(Isolate* isolate) {

return Handle<ObjectTemplateInfo>::cast(

isolate->eternal_handles()->GetSingleton(field));

}

- v8::Local<v8::ObjectTemplate> raw_template(v8::ObjectTemplate::New());

+ v8::Local<v8::ObjectTemplate> raw_template =

+ v8::ObjectTemplate::New(reinterpret_cast<v8::Isolate*>(isolate));

raw_template->SetInternalFieldCount(internal_fields);

return Handle<ObjectTemplateInfo>::cast(

isolate->eternal_handles()->CreateSingleton(

« no previous file with comments | « src/d8.cc ('k') | test/cctest/test-accessors.cc » ('j') | no next file with comments »