Perl IDL parser: allow extended attributes to have more than 2 values

Perl IDL parser: allow extended attributes to have more than 2 values

The (Perl) IDL parser has a bug, limiting extended attribute value lists
to being length at most 2.
This hasn't been a problem in the past, since this isn't used, but caused
a problem in a recent CL where arbitrarily long lists are common.
This fixes it; it's a 2-line fix.

Relevant CL:
Support IDL attributes limited to only known values.
https://codereview.chromium.org/124763002/

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164500

[Nils Barth (inactive), 2014-01-06 07:09:52]

Quick fix to the parser bug Sigbjørn identified.

https://codereview.chromium.org/124943002/diff/1/Source/bindings/scripts/idl_...
File Source/bindings/scripts/idl_parser.pm (right):

https://codereview.chromium.org/124943002/diff/1/Source/bindings/scripts/idl_...
Source/bindings/scripts/idl_parser.pm:1634: return $name . "&" .
$self->parseExtendedAttributeRest2();
To explain the crypticness:
parseExtendedAttributeRest*2* parses an extended attribute value,
extracting an identifier and then calling parseExtendedAttributeRest*3*
to handle the tail -- &|(,] etc.
Thus for &| we should mutually recurse back to *2* to build a list.
Existing code is buggy b/c it instead requires that the tail be
a single identifier, not a list, thus limiting list length to 2.

(Not commenting in existing parser Perl code b/c this is going away
soon, and it's much simpler in the Python parser.)

[haraken, 2014-01-06 07:16:10]

LGTM

[commit-bot: I haz the power, 2014-01-06 07:19:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/124943002/1

[sof, 2014-01-06 07:25:00]

awesome, thanks :)

[commit-bot: I haz the power, 2014-01-06 08:32:41]

List of reviewers changed. sigbjornf@opera.com did a drive-by without LGTM'ing!

[sof, 2014-01-06 08:34:10]

what? lgtm.

[commit-bot: I haz the power, 2014-01-06 09:54:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/124943002/1

[commit-bot: I haz the power, 2014-01-06 09:54:55]

Change committed as 164500