Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10009)

Unified Diff: chrome/browser/webdata/autocomplete_syncable_service.cc

Issue 12494020: Remove knowledge of Chrome-specific SyncableService classes from WebDataService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit test in debug mode. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/webdata/autocomplete_syncable_service.cc
diff --git a/chrome/browser/webdata/autocomplete_syncable_service.cc b/chrome/browser/webdata/autocomplete_syncable_service.cc
index f039075cf83f2cfd69efb5373f1a1c92794ad1c5..e3499c2946a91e0638157f55653357f434727364 100644
--- a/chrome/browser/webdata/autocomplete_syncable_service.cc
+++ b/chrome/browser/webdata/autocomplete_syncable_service.cc
@@ -79,6 +79,13 @@ bool MergeTimestamps(const sync_pb::AutofillSpecifics& autofill,
}
}
+void* UserDataKey() {
+ // Use the address of a static that COMDAT folding won't ever fold
+ // with something else.
+ static int user_data_key = 0;
+ return reinterpret_cast<void*>(&user_data_key);
+}
+
} // namespace
AutocompleteSyncableService::AutocompleteSyncableService(
@@ -96,6 +103,20 @@ AutocompleteSyncableService::~AutocompleteSyncableService() {
DCHECK(CalledOnValidThread());
}
+// static
+void AutocompleteSyncableService::CreateForWebDataService(
+ WebDataService* web_data) {
+ web_data->GetDBUserData()->SetUserData(
+ UserDataKey(), new AutocompleteSyncableService(web_data));
+}
+
+// static
+AutocompleteSyncableService* AutocompleteSyncableService::FromWebDataService(
+ WebDataService* web_data) {
+ return static_cast<AutocompleteSyncableService*>(
+ web_data->GetDBUserData()->GetUserData(UserDataKey()));
+}
+
AutocompleteSyncableService::AutocompleteSyncableService()
: web_data_service_(NULL),
cull_expired_entries_(false) {
« no previous file with comments | « chrome/browser/webdata/autocomplete_syncable_service.h ('k') | chrome/browser/webdata/autofill_profile_syncable_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698