Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Side by Side Diff: chrome/browser/webdata/autocomplete_syncable_service.cc

Issue 12494020: Remove knowledge of Chrome-specific SyncableService classes from WebDataService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit test in debug mode. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/webdata/autocomplete_syncable_service.h" 5 #include "chrome/browser/webdata/autocomplete_syncable_service.h"
6 6
7 #include "base/location.h" 7 #include "base/location.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 return true; 72 return true;
73 } else { 73 } else {
74 new_timestamps->insert(new_timestamps->begin(), 74 new_timestamps->insert(new_timestamps->begin(),
75 timestamps.begin(), 75 timestamps.begin(),
76 timestamps.end()); 76 timestamps.end());
77 return false; 77 return false;
78 } 78 }
79 } 79 }
80 } 80 }
81 81
82 void* UserDataKey() {
83 // Use the address of a static that COMDAT folding won't ever fold
84 // with something else.
85 static int user_data_key = 0;
86 return reinterpret_cast<void*>(&user_data_key);
87 }
88
82 } // namespace 89 } // namespace
83 90
84 AutocompleteSyncableService::AutocompleteSyncableService( 91 AutocompleteSyncableService::AutocompleteSyncableService(
85 WebDataService* web_data_service) 92 WebDataService* web_data_service)
86 : web_data_service_(web_data_service), 93 : web_data_service_(web_data_service),
87 cull_expired_entries_(false) { 94 cull_expired_entries_(false) {
88 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB)); 95 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
89 DCHECK(web_data_service_); 96 DCHECK(web_data_service_);
90 notification_registrar_.Add( 97 notification_registrar_.Add(
91 this, chrome::NOTIFICATION_AUTOFILL_ENTRIES_CHANGED, 98 this, chrome::NOTIFICATION_AUTOFILL_ENTRIES_CHANGED,
92 content::Source<WebDataService>(web_data_service)); 99 content::Source<WebDataService>(web_data_service));
93 } 100 }
94 101
95 AutocompleteSyncableService::~AutocompleteSyncableService() { 102 AutocompleteSyncableService::~AutocompleteSyncableService() {
96 DCHECK(CalledOnValidThread()); 103 DCHECK(CalledOnValidThread());
97 } 104 }
98 105
106 // static
107 void AutocompleteSyncableService::CreateForWebDataService(
108 WebDataService* web_data) {
109 web_data->GetDBUserData()->SetUserData(
110 UserDataKey(), new AutocompleteSyncableService(web_data));
111 }
112
113 // static
114 AutocompleteSyncableService* AutocompleteSyncableService::FromWebDataService(
115 WebDataService* web_data) {
116 return static_cast<AutocompleteSyncableService*>(
117 web_data->GetDBUserData()->GetUserData(UserDataKey()));
118 }
119
99 AutocompleteSyncableService::AutocompleteSyncableService() 120 AutocompleteSyncableService::AutocompleteSyncableService()
100 : web_data_service_(NULL), 121 : web_data_service_(NULL),
101 cull_expired_entries_(false) { 122 cull_expired_entries_(false) {
102 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB)); 123 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
103 } 124 }
104 125
105 syncer::SyncMergeResult AutocompleteSyncableService::MergeDataAndStartSyncing( 126 syncer::SyncMergeResult AutocompleteSyncableService::MergeDataAndStartSyncing(
106 syncer::ModelType type, 127 syncer::ModelType type,
107 const syncer::SyncDataList& initial_sync_data, 128 const syncer::SyncDataList& initial_sync_data,
108 scoped_ptr<syncer::SyncChangeProcessor> sync_processor, 129 scoped_ptr<syncer::SyncChangeProcessor> sync_processor,
(...skipping 348 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 UTF16ToUTF8(entry.key().value()))); 478 UTF16ToUTF8(entry.key().value())));
458 return syncer::SyncData::CreateLocalData(tag, tag, autofill_specifics); 479 return syncer::SyncData::CreateLocalData(tag, tag, autofill_specifics);
459 } 480 }
460 481
461 // static 482 // static
462 std::string AutocompleteSyncableService::KeyToTag(const std::string& name, 483 std::string AutocompleteSyncableService::KeyToTag(const std::string& name,
463 const std::string& value) { 484 const std::string& value) {
464 std::string ns(kAutofillEntryNamespaceTag); 485 std::string ns(kAutofillEntryNamespaceTag);
465 return ns + net::EscapePath(name) + "|" + net::EscapePath(value); 486 return ns + net::EscapePath(name) + "|" + net::EscapePath(value);
466 } 487 }
OLDNEW
« no previous file with comments | « chrome/browser/webdata/autocomplete_syncable_service.h ('k') | chrome/browser/webdata/autofill_profile_syncable_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698