Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5082)

Unified Diff: chrome/browser/webdata/web_data_service.cc

Issue 12494020: Remove knowledge of Chrome-specific SyncableService classes from WebDataService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/webdata/web_data_service.cc
diff --git a/chrome/browser/webdata/web_data_service.cc b/chrome/browser/webdata/web_data_service.cc
index e1611acd5935830ee89488ca77901dc4d49def53..a3959467e8164a18c8de942fa09a0ae97003fa51 100644
--- a/chrome/browser/webdata/web_data_service.cc
+++ b/chrome/browser/webdata/web_data_service.cc
@@ -4,11 +4,10 @@
#include "chrome/browser/webdata/web_data_service.h"
+#include "base/stl_util.h"
#include "chrome/browser/search_engines/template_url.h"
-#include "chrome/browser/webdata/autocomplete_syncable_service.h"
#include "chrome/browser/webdata/autofill_change.h"
#include "chrome/browser/webdata/autofill_entry.h"
-#include "chrome/browser/webdata/autofill_profile_syncable_service.h"
#include "chrome/browser/webdata/autofill_table.h"
#include "chrome/browser/webdata/keyword_table.h"
#include "chrome/browser/webdata/logins_table.h"
@@ -64,9 +63,7 @@ WDKeywordsResult::WDKeywordsResult()
WDKeywordsResult::~WDKeywordsResult() {}
WebDataService::WebDataService(const ProfileErrorCallback& callback)
- : WebDataServiceBase(callback),
- autocomplete_syncable_service_(NULL),
- autofill_profile_syncable_service_(NULL) {
+ : WebDataServiceBase(callback) {
}
// static
@@ -83,18 +80,6 @@ void WebDataService::NotifyOfMultipleAutofillChanges(
make_scoped_refptr(web_data_service)));
}
-void WebDataService::ShutdownOnUIThread() {
- BrowserThread::PostTask(BrowserThread::DB, FROM_HERE,
- Bind(&WebDataService::ShutdownSyncableServices, this));
- WebDataServiceBase::ShutdownOnUIThread();
-}
-
-void WebDataService::Init(const base::FilePath& path) {
- WebDataServiceBase::Init(path);
- BrowserThread::PostTask(BrowserThread::DB, FROM_HERE,
- Bind(&WebDataService::InitializeSyncableServices, this));
-}
-
//////////////////////////////////////////////////////////////////////////////
//
// Keywords.
@@ -277,32 +262,6 @@ void WebDataService::RemoveAutofillProfilesAndCreditCardsModifiedBetween(
}
WebDataService::~WebDataService() {
- DCHECK(!autocomplete_syncable_service_);
- DCHECK(!autofill_profile_syncable_service_);
-}
-
-////////////////////////////////////////////////////////////////////////////////
-//
-// The following methods are executed on the DB thread.
-//
-////////////////////////////////////////////////////////////////////////////////
-
-void WebDataService::InitializeSyncableServices() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
- DCHECK(!autocomplete_syncable_service_);
- DCHECK(!autofill_profile_syncable_service_);
-
- autocomplete_syncable_service_ = new AutocompleteSyncableService(this);
- autofill_profile_syncable_service_ = new AutofillProfileSyncableService(this);
-}
-
-void WebDataService::ShutdownSyncableServices() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
-
- delete autocomplete_syncable_service_;
- autocomplete_syncable_service_ = NULL;
- delete autofill_profile_syncable_service_;
- autofill_profile_syncable_service_ = NULL;
}
////////////////////////////////////////////////////////////////////////////////
@@ -679,22 +638,6 @@ WebDataService::RemoveAutofillProfilesAndCreditCardsModifiedBetweenImpl(
return WebDatabase::COMMIT_NOT_NEEDED;
}
-AutofillProfileSyncableService*
- WebDataService::GetAutofillProfileSyncableService() const {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
- DCHECK(autofill_profile_syncable_service_); // Make sure we're initialized.
-
- return autofill_profile_syncable_service_;
-}
-
-AutocompleteSyncableService* WebDataService::GetAutocompleteSyncableService()
- const {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
- DCHECK(autocomplete_syncable_service_); // Make sure we're initialized.
-
- return autocomplete_syncable_service_;
-}
-
void WebDataService::DestroyAutofillProfileResult(const WDTypedResult* result) {
DCHECK(result->GetType() == AUTOFILL_PROFILES_RESULT);
const WDResult<std::vector<AutofillProfile*> >* r =

Powered by Google App Engine
This is Rietveld 408576698