chrome/browser/webdata/autocomplete_syncable_service.h - Issue 12494020: Remove knowledge of Chrome-specific SyncableService classes from WebDataService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/webdata/autocomplete_syncable_service.h

Issue 12494020: Remove knowledge of Chrome-specific SyncableService classes from WebDataService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_service_autofill_unittest.cc ('k') | chrome/browser/webdata/autocomplete_syncable_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/webdata/autocomplete_syncable_service.h

diff --git a/chrome/browser/webdata/autocomplete_syncable_service.h b/chrome/browser/webdata/autocomplete_syncable_service.h

index 3a0a5c9cd90f4b25fdf3f7c6b8901b93a2932286..2cf1fb37f75b0500d62beb5e5055b76d1e11d494 100644

--- a/chrome/browser/webdata/autocomplete_syncable_service.h

+++ b/chrome/browser/webdata/autocomplete_syncable_service.h

@@ -47,6 +47,13 @@ class AutocompleteSyncableService

explicit AutocompleteSyncableService(WebDataService* web_data_service);

virtual ~AutocompleteSyncableService();

+ // Retrieves the AutocompleteSyncableService stored on |web_data|.

+ static AutocompleteSyncableService* FromWebData(WebDataServiceBase* web_data);

+ static void AttachToWebData(scoped_ptr<AutocompleteSyncableService> service,

+ WebDataServiceBase* web_data);

Ilya Sherman 2013/03/18 21:24:48 Why not follow the pattern used elsewhere in the A

Jói 2013/03/18 22:11:34 I was aware of the pattern but didn't think to app

static syncer::ModelType model_type() { return syncer::AUTOFILL; }

// syncer::SyncableService implementation.