Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 12493009: Delete usage of obsolete macros (Closed)

Created:
7 years, 9 months ago by abarth-chromium
Modified:
7 years, 9 months ago
Reviewers:
tony
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Delete usage of obsolete macros We always use V8 these days and never use JSC. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187660

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M webkit/glue/cpp_bound_class.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/glue/webkit_glue.cc View 1 chunk +0 lines, -2 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
abarth-chromium
Easy review. :)
7 years, 9 months ago (2013-03-12 09:29:05 UTC) #1
tony
LGTM https://codereview.chromium.org/12493009/diff/1/webkit/glue/webkit_glue.cc File webkit/glue/webkit_glue.cc (left): https://codereview.chromium.org/12493009/diff/1/webkit/glue/webkit_glue.cc#oldcode92 webkit/glue/webkit_glue.cc:92: #if WEBKIT_USING_V8 Can we remove the definition of ...
7 years, 9 months ago (2013-03-12 16:58:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/12493009/1
7 years, 9 months ago (2013-03-12 16:59:12 UTC) #3
abarth-chromium
https://codereview.chromium.org/12493009/diff/1/webkit/glue/webkit_glue.cc File webkit/glue/webkit_glue.cc (left): https://codereview.chromium.org/12493009/diff/1/webkit/glue/webkit_glue.cc#oldcode92 webkit/glue/webkit_glue.cc:92: #if WEBKIT_USING_V8 On 2013/03/12 16:58:51, tony wrote: > Can ...
7 years, 9 months ago (2013-03-12 17:30:51 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-12 22:09:28 UTC) #5
Message was sent while issue was closed.
Change committed as 187660

Powered by Google App Engine
This is Rietveld 408576698