build/toolchain.gypi - Issue 1249273003: [build] Disable linker threading in LTO builds, as it causes intermittent link failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain.gypi

Issue 1249273003: [build] Disable linker threading in LTO builds, as it causes intermittent link failures. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/toolchain.gypi

diff --git a/build/toolchain.gypi b/build/toolchain.gypi

index 4dbf42bfe3795c6ba16ab24dcef82914dd8dadd5..a8a3b56ec22a2b761cfff51f95dc393b38000649 100644

--- a/build/toolchain.gypi

+++ b/build/toolchain.gypi

@@ -1149,7 +1149,9 @@

}],

- ['linux_use_gold_flags==1', {

+ # TODO(pcc): Re-enable in LTO builds once we've fixed the intermittent

+ # link failures (crbug.com/513074).

+ ['linux_use_gold_flags==1 and use_lto==0', {

'target_conditions': [

['_toolset=="target"', {

'ldflags': [

« no previous file with comments | « no previous file | no next file » | no next file with comments »