Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: build/toolchain.gypi

Issue 1249273003: [build] Disable linker threading in LTO builds, as it causes intermittent link failures. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 the V8 project authors. All rights reserved. 1 # Copyright 2013 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 1131 matching lines...) Expand 10 before | Expand all | Expand 10 after
1142 ['android_full_debug==0', { 1142 ['android_full_debug==0', {
1143 # Disable full debug if we want a faster v8 in a debug build. 1143 # Disable full debug if we want a faster v8 in a debug build.
1144 # TODO(2304): pass DISABLE_DEBUG_ASSERT instead of hiding DEBUG. 1144 # TODO(2304): pass DISABLE_DEBUG_ASSERT instead of hiding DEBUG.
1145 'defines!': [ 1145 'defines!': [
1146 'DEBUG', 1146 'DEBUG',
1147 'ENABLE_SLOW_DCHECKS', 1147 'ENABLE_SLOW_DCHECKS',
1148 ], 1148 ],
1149 }], 1149 }],
1150 ], 1150 ],
1151 }], 1151 }],
1152 ['linux_use_gold_flags==1', { 1152 # TODO(pcc): Re-enable in LTO builds once we've fixed the intermittent
1153 # link failures (crbug.com/513074).
1154 ['linux_use_gold_flags==1 and use_lto==0', {
1153 'target_conditions': [ 1155 'target_conditions': [
1154 ['_toolset=="target"', { 1156 ['_toolset=="target"', {
1155 'ldflags': [ 1157 'ldflags': [
1156 # Experimentation found that using four linking threads 1158 # Experimentation found that using four linking threads
1157 # saved ~20% of link time. 1159 # saved ~20% of link time.
1158 # https://groups.google.com/a/chromium.org/group/chromium-dev/ browse_thread/thread/281527606915bb36 1160 # https://groups.google.com/a/chromium.org/group/chromium-dev/ browse_thread/thread/281527606915bb36
1159 # Only apply this to the target linker, since the host 1161 # Only apply this to the target linker, since the host
1160 # linker might not be gold, but isn't used much anyway. 1162 # linker might not be gold, but isn't used much anyway.
1161 '-Wl,--threads', 1163 '-Wl,--threads',
1162 '-Wl,--thread-count=4', 1164 '-Wl,--thread-count=4',
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
1252 ['v8_enable_slow_dchecks==1', { 1254 ['v8_enable_slow_dchecks==1', {
1253 'defines': [ 1255 'defines': [
1254 'ENABLE_SLOW_DCHECKS', 1256 'ENABLE_SLOW_DCHECKS',
1255 ], 1257 ],
1256 }], 1258 }],
1257 ], # conditions 1259 ], # conditions
1258 }, # Release 1260 }, # Release
1259 }, # configurations 1261 }, # configurations
1260 }, # target_defaults 1262 }, # target_defaults
1261 } 1263 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698