Issue 1249163002: Fixed Bluetooth keyboard pairing pincode visibility issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1249163002: Fixed Bluetooth keyboard pairing pincode visibility issue. (Closed)

Created:
5 years, 5 months ago by dzhioev (left Google)

Modified:
5 years, 5 months ago

Reviewers:

CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2454

Target Ref:
refs/pending/branch-heads/2454

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fixed Bluetooth keyboard pairing pincode visibility issue. The problem was that the UI expected that CONTEXT_KEY_KEYBOARD_STATE key observer is called before CONTEXT_KEY_KEYBOARD_PINCODE observer. In fact, the order of notifications was never defined. It have changed at some point, which lead to regression. BUG=507896 TEST=OobeWebUITest.HIDDetectionScreenTest browser test Review URL: https://codereview.chromium.org/1243983002 Cr-Commit-Position: refs/heads/master@{#339767} (cherry picked from commit 401b76f576d114925c2291426e0e91d1853ad58e) Committed: https://chromium.googlesource.com/chromium/src/+/d6dd943c6b3c0e8b623c5b175af0468c58af060d

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -45 lines)			Patch
M	chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.css	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js	View	4 chunks	+33 lines, -39 lines	0 comments	Download
M	chrome/test/data/chromeos/oobe_webui_browsertest.js	View	1 chunk	+55 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

dzhioev (left Google)

5 years, 5 months ago (2015-07-22 23:27:29 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d6dd943c6b3c0e8b623c5b175af0468c58af060d.

Expand Messages | Collapse Messages