Fixed Bluetooth keyboard pairing pincode visibility issue.

Fixed Bluetooth keyboard pairing pincode visibility issue.

The problem was that the UI expected that CONTEXT_KEY_KEYBOARD_STATE key
observer is called before CONTEXT_KEY_KEYBOARD_PINCODE observer. In fact, the
order of notifications was never defined. It have changed at some point, which
lead to regression.

BUG=507896
TEST=OobeWebUITest.HIDDetectionScreenTest browser test

Committed: https://crrev.com/401b76f576d114925c2291426e0e91d1853ad58e
Cr-Commit-Position: refs/heads/master@{#339767}

[dzhioev (left Google), 2015-07-21 06:12:34]

dzhioev@chromium.org changed reviewers:
+ rsorokin@chromium.org

[dzhioev (left Google), 2015-07-21 06:12:43]

Roman, PTAL

[Roman Sorokin (ftl), 2015-07-21 12:10:58]

lgtm with nits

https://codereview.chromium.org/1243983002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js
(right):

https://codereview.chromium.org/1243983002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js:184: if
(pincode.length != 6)
nit: Why not create the constant stores 6-value?

https://codereview.chromium.org/1243983002/diff/20001/chrome/test/data/chrome...
File chrome/test/data/chromeos/oobe_webui_browsertest.js (right):

https://codereview.chromium.org/1243983002/diff/20001/chrome/test/data/chrome...
chrome/test/data/chromeos/oobe_webui_browsertest.js:139: var pincode  = '';
nit: remove one space before '=';

[dzhioev (left Google), 2015-07-21 21:06:06]

https://codereview.chromium.org/1243983002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js
(right):

https://codereview.chromium.org/1243983002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js:184: if
(pincode.length != 6)
On 2015/07/21 12:10:58, Roman Sorokin wrote:
> nit: Why not create the constant stores 6-value?

Done.

https://codereview.chromium.org/1243983002/diff/20001/chrome/test/data/chrome...
File chrome/test/data/chromeos/oobe_webui_browsertest.js (right):

https://codereview.chromium.org/1243983002/diff/20001/chrome/test/data/chrome...
chrome/test/data/chromeos/oobe_webui_browsertest.js:139: var pincode  = '';
On 2015/07/21 12:10:58, Roman Sorokin wrote:
> nit: remove one space before '=';

Done.

[dzhioev (left Google), 2015-07-21 21:06:36]

The CQ bit was checked by dzhioev@chromium.org

[dzhioev (left Google), 2015-07-21 21:06:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
rsorokin@chromium.org
Link to the patchset: https://codereview.chromium.org/1243983002/#ps40001
(title: "Comments addressed.")

[commit-bot: I haz the power, 2015-07-21 21:07:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1243983002/40001

[commit-bot: I haz the power, 2015-07-21 22:29:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-21 22:30:56]

Patchset 3 (id:??) landed as
https://crrev.com/401b76f576d114925c2291426e0e91d1853ad58e
Cr-Commit-Position: refs/heads/master@{#339767}