content/browser/frame_host/render_widget_host_view_guest.h - Issue 1249013005: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_guest.h

Issue 1249013005: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_widget_host_view_child_frame.cc ('k') | content/browser/frame_host/render_widget_host_view_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_guest.h

diff --git a/content/browser/frame_host/render_widget_host_view_guest.h b/content/browser/frame_host/render_widget_host_view_guest.h

index 0201580474d3e61888d64a2d7d6dfc1dd4a3b2bd..8ab05e925c03f9bbc1bfdac39a6e8f1dfcf1a1a0 100644

--- a/content/browser/frame_host/render_widget_host_view_guest.h

+++ b/content/browser/frame_host/render_widget_host_view_guest.h

@@ -18,6 +18,8 @@

#include "ui/gfx/geometry/vector2d_f.h"

#include "ui/gfx/native_widget_types.h"

+struct ViewHostMsg_TextInputState_Params;

namespace content {

class BrowserPluginGuest;

class RenderWidgetHost;

@@ -72,10 +74,8 @@ class CONTENT_EXPORT RenderWidgetHostViewGuest

void MovePluginWindows(const std::vector<WebPluginGeometry>& moves) override;

void UpdateCursor(const WebCursor& cursor) override;

void SetIsLoading(bool is_loading) override;

- void TextInputTypeChanged(ui::TextInputType type,

- ui::TextInputMode input_mode,

- bool can_compose_inline,

- int flags) override;

+ void TextInputStateChanged(

+ const ViewHostMsg_TextInputState_Params& params) override;

void ImeCancelComposition() override;

#if defined(OS_MACOSX) || defined(USE_AURA)

void ImeCompositionRangeChanged(