content/browser/frame_host/render_widget_host_view_guest.cc - Issue 1249013005: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_guest.cc

Issue 1249013005: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_widget_host_view_guest.h ('k') | content/browser/renderer_host/render_widget_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_guest.cc

diff --git a/content/browser/frame_host/render_widget_host_view_guest.cc b/content/browser/frame_host/render_widget_host_view_guest.cc

index b06464e2a0a2400899b78ea5f1748eb9898810bd..f5a04c4cc6fb1e2c152e847173fabf94ac7f013d 100644

--- a/content/browser/frame_host/render_widget_host_view_guest.cc

+++ b/content/browser/frame_host/render_widget_host_view_guest.cc

@@ -355,11 +355,8 @@ void RenderWidgetHostViewGuest::SetIsLoading(bool is_loading) {

platform_view_->SetIsLoading(is_loading);

}

-void RenderWidgetHostViewGuest::TextInputTypeChanged(

- ui::TextInputType type,

- ui::TextInputMode input_mode,

- bool can_compose_inline,

- int flags) {

+void RenderWidgetHostViewGuest::TextInputStateChanged(

+ const ViewHostMsg_TextInputState_Params& params) {

if (!guest_)

return;

@@ -367,7 +364,7 @@ void RenderWidgetHostViewGuest::TextInputTypeChanged(

if (!rwhv)

return;

// Forward the information to embedding RWHV.

- rwhv->TextInputTypeChanged(type, input_mode, can_compose_inline, flags);

+ rwhv->TextInputStateChanged(params);

}

void RenderWidgetHostViewGuest::ImeCancelComposition() {