Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1249013005: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 3f20613ad0764261359075f888452e7757b99795..9ac8ecfc6d1ce07129cbdb1530067eebb89c0ebe 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -799,7 +799,8 @@ void RenderFrameImpl::PepperTextInputTypeChanged(
if (instance != render_view_->focused_pepper_plugin())
return;
- GetRenderWidget()->UpdateTextInputType();
+ GetRenderWidget()->UpdateTextInputState(
+ RenderWidget::NO_SHOW_IME, RenderWidget::FROM_NON_IME);
FocusedNodeChangedForAccessibility(WebNode());
}
@@ -3014,17 +3015,14 @@ void RenderFrameImpl::didChangeSelection(bool is_empty_selection) {
if (is_empty_selection)
selection_text_.clear();
- // UpdateTextInputType should be called before SyncSelectionIfRequired.
- // UpdateTextInputType may send TextInputTypeChanged to notify the focus
+ // UpdateTextInputState should be called before SyncSelectionIfRequired.
+ // UpdateTextInputState may send TextInputStateChanged to notify the focus
// was changed, and SyncSelectionIfRequired may send SelectionChanged
// to notify the selection was changed. Focus change should be notified
// before selection change.
- GetRenderWidget()->UpdateTextInputType();
+ GetRenderWidget()->UpdateTextInputState(
+ RenderWidget::NO_SHOW_IME, RenderWidget::FROM_NON_IME);
SyncSelectionIfRequired();
-#if defined(OS_ANDROID)
- GetRenderWidget()->UpdateTextInputState(RenderWidget::NO_SHOW_IME,
- RenderWidget::FROM_NON_IME);
-#endif
}
blink::WebColorChooser* RenderFrameImpl::createColorChooser(

Powered by Google App Engine
This is Rietveld 408576698