content/renderer/npapi/webplugin_delegate_proxy.cc - Issue 1249013005: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/npapi/webplugin_delegate_proxy.cc

Issue 1249013005: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_widget_host_view_aura.cc ('K') | « content/common/view_messages.h ('k') | content/renderer/render_frame_impl.cc » ('j') | content/renderer/render_widget.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/npapi/webplugin_delegate_proxy.cc

diff --git a/content/renderer/npapi/webplugin_delegate_proxy.cc b/content/renderer/npapi/webplugin_delegate_proxy.cc

index 0ba60f240f116f9cdf4813f360643543a0640b78..59ef01ee12e7910eef53f0c5333b1344e1f119e2 100644

--- a/content/renderer/npapi/webplugin_delegate_proxy.cc

+++ b/content/renderer/npapi/webplugin_delegate_proxy.cc

@@ -911,11 +911,12 @@ void WebPluginDelegateProxy::OnNotifyIMEStatus(int input_type,

if (!render_view_)

return;

- render_view_->Send(new ViewHostMsg_TextInputTypeChanged(

- render_view_->routing_id(),

- static_cast<ui::TextInputType>(input_type),

- ui::TEXT_INPUT_MODE_DEFAULT,

- true, 0));

+ ViewHostMsg_TextInputState_Params p;

nasko 2015/07/29 17:41:07 nit: s/p/params/

Shu Chen 2015/07/30 00:47:22 Done.

+ p.type = static_cast<ui::TextInputType>(input_type);

+ p.mode = ui::TEXT_INPUT_MODE_DEFAULT;

+ p.can_compose_inline = true;

+ render_view_->Send(new ViewHostMsg_TextInputStateChanged(

+ render_view_->routing_id(), p));

ViewHostMsg_SelectionBounds_Params bounds_params;

bounds_params.anchor_rect = bounds_params.focus_rect = caret_rect;