Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: Source/devtools/front_end/sdk/Script.js

Issue 1249013002: DevTools: simplify setScriptSource and restartFrame return values (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed dgozman's comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/sdk/DebuggerModel.js ('k') | Source/devtools/protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/Script.js
diff --git a/Source/devtools/front_end/sdk/Script.js b/Source/devtools/front_end/sdk/Script.js
index 20b889556ba29c1e808d0b9a3fd56b517082897c..ad8ad27f32dd89cc9b9d57f0979f0990aab58e70 100644
--- a/Source/devtools/front_end/sdk/Script.js
+++ b/Source/devtools/front_end/sdk/Script.js
@@ -193,15 +193,14 @@ WebInspector.Script.prototype = {
* @param {?Protocol.Error} error
* @param {!DebuggerAgent.SetScriptSourceError=} errorData
* @param {!Array.<!DebuggerAgent.CallFrame>=} callFrames
- * @param {!Object=} debugData
+ * @param {boolean=} stackChanged
* @param {!DebuggerAgent.StackTrace=} asyncStackTrace
*/
- function didEditScriptSource(error, errorData, callFrames, debugData, asyncStackTrace)
+ function didEditScriptSource(error, errorData, callFrames, stackChanged, asyncStackTrace)
{
- // FIXME: support debugData.stack_update_needs_step_in flag by calling WebInspector.debugger_model.callStackModified
if (!error)
this._source = newSource;
- var needsStepIn = !!debugData && debugData["stack_update_needs_step_in"] === true;
+ var needsStepIn = !!stackChanged;
callback(error, errorData, callFrames, asyncStackTrace, needsStepIn);
if (!error)
this.dispatchEventToListeners(WebInspector.Script.Events.ScriptEdited, newSource);
« no previous file with comments | « Source/devtools/front_end/sdk/DebuggerModel.js ('k') | Source/devtools/protocol.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698