Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3468)

Unified Diff: chrome/browser/ui/webui/help/help_handler.cc

Issue 12490012: Send Feedback Experiment (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: whitespace Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/help/help_handler.cc
diff --git a/chrome/browser/ui/webui/help/help_handler.cc b/chrome/browser/ui/webui/help/help_handler.cc
index 9f5dce9fb4c341ae4f8cf2bccf5544e9cc65ac4b..f268474362d5088ec0ae7f4090a696ed85fd685e 100644
--- a/chrome/browser/ui/webui/help/help_handler.cc
+++ b/chrome/browser/ui/webui/help/help_handler.cc
@@ -20,6 +20,7 @@
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/chrome_pages.h"
+#include "chrome/browser/ui/send_feedback_experiment.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/chrome_version_info.h"
#include "chrome/common/url_constants.h"
@@ -161,6 +162,16 @@ void HelpHandler::GetLocalizedValues(content::WebUIDataSource* source) {
#endif
};
+ if (chrome::send_feedback_experiment::UseAlternateText()) {
+ const std::string sResourceReportIssue = "reportAnIssue";
SteveT 2013/03/19 14:38:58 nit: does the "s" stand for "string" in sResourceR
Harry McCleave 2013/03/19 22:23:29 Done.
+ // Finch experiment to substitute "Report an Issue"
SteveT 2013/03/19 14:38:58 Please avoid using the term "Finch". You can just
Harry McCleave 2013/03/19 22:23:29 Done.
+ // with "Send Feedback" crbug.com/169339.
+ for (size_t i = 0; i < ARRAYSIZE_UNSAFE(resources); ++i) {
+ if (sResourceReportIssue == resources[i].name)
+ resources[i].ids = IDS_SEND_FEEDBACK;
+ }
+ }
+
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(resources); ++i) {
source->AddString(resources[i].name,
l10n_util::GetStringUTF16(resources[i].ids));

Powered by Google App Engine
This is Rietveld 408576698