Send Feedback Experiment

chrome/browser/ui/webui/help/help_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/help/help_handler.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/string16.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/google/google_util.h"
 #include "chrome/browser/policy/browser_policy_connector.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/chrome_pages.h"
+#include "chrome/browser/ui/send_feedback_experiment.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_version_info.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/web_ui.h"
 #include "content/public/browser/web_ui_data_source.h"
 #include "content/public/common/content_client.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
@@ skipping 121 matching lines @@
     { "userAgent", IDS_ABOUT_VERSION_USER_AGENT },
     { "commandLine", IDS_ABOUT_VERSION_COMMAND_LINE },
     { "buildDate", IDS_ABOUT_VERSION_BUILD_DATE },
 #endif
 #if defined(OS_MACOSX)
     { "promote", IDS_ABOUT_CHROME_PROMOTE_UPDATER },
     { "learnMore", IDS_LEARN_MORE },
 #endif
   };
 
+  if (chrome::send_feedback_experiment::UseAlternateText()) {
+    const std::string sResourceReportIssue = "reportAnIssue";

[SteveT, 2013/03/19 14:38:58]

nit: does the "s" stand for "string" in sResourceReportIssue? Not sure if this
fits our variable naming convention...

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Local_...

[Harry McCleave, 2013/03/19 22:23:29]

Done.

+    // Finch experiment to substitute "Report an Issue"

[SteveT, 2013/03/19 14:38:58]

Please avoid using the term "Finch". You can just say "experiment" or "field
trial".

[Harry McCleave, 2013/03/19 22:23:29]

Done.

+    // with "Send Feedback" crbug.com/169339.
+    for (size_t i = 0; i < ARRAYSIZE_UNSAFE(resources); ++i) {
+      if (sResourceReportIssue == resources[i].name)
+        resources[i].ids = IDS_SEND_FEEDBACK;
+    }
+  }
+
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(resources); ++i) {
     source->AddString(resources[i].name,
                       l10n_util::GetStringUTF16(resources[i].ids));
   }
 
   source->AddString(
       "browserVersion",
       l10n_util::GetStringFUTF16(IDS_ABOUT_PRODUCT_VERSION,
                                  BuildBrowserVersionString()));
 
@@ skipping 260 matching lines @@
 
     // Note that this string will be internationalized.
     string16 build_date = base::TimeFormatFriendlyDate(time);
     g_build_date_string = Value::CreateStringValue(build_date);
   }
 
   web_ui()->CallJavascriptFunction("help.HelpPage.setBuildDate",
                                    *g_build_date_string);
 }
 #endif // defined(OS_CHROMEOS)