Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1248973002: Eliminate redundant descriptor ElementTransitionAndStoreDescriptor. (Closed)

Created:
5 years, 5 months ago by mvstanton
Modified:
5 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Eliminate redundant descriptor ElementTransitionAndStoreDescriptor. It's just the same as StoreTransitionDescriptor. BUG= Committed: https://crrev.com/26ffee2c718308bb85be072ed32479e4aa8e7e6b Cr-Commit-Position: refs/heads/master@{#29789}

Patch Set 1 #

Patch Set 2 : Ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -82 lines) Patch
M src/arm/interface-descriptors-arm.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/code-stubs.h View 1 chunk +1 line, -23 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ic/arm/access-compiler-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ic/arm/ic-compiler-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ic/arm64/access-compiler-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ic/arm64/ic-compiler-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ia32/access-compiler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ia32/ic-compiler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M src/ic/mips/access-compiler-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips/ic-compiler-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips64/access-compiler-mips64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips64/ic-compiler-mips64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ic/x64/access-compiler-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ic/x64/ic-compiler-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/interface-descriptors.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Jakob, Here is the change we discussed, thanks for the look! --Michael
5 years, 5 months ago (2015-07-22 11:51:59 UTC) #2
Jakob Kummerow
lgtm
5 years, 5 months ago (2015-07-22 11:58:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248973002/20001
5 years, 5 months ago (2015-07-22 12:07:14 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-22 12:37:19 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 12:37:39 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/26ffee2c718308bb85be072ed32479e4aa8e7e6b
Cr-Commit-Position: refs/heads/master@{#29789}

Powered by Google App Engine
This is Rietveld 408576698