Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: src/ic/arm/ic-compiler-arm.cc

Issue 1248973002: Eliminate redundant descriptor ElementTransitionAndStoreDescriptor. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ports. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm/access-compiler-arm.cc ('k') | src/ic/arm64/access-compiler-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/ic/ic.h" 9 #include "src/ic/ic.h"
10 #include "src/ic/ic-compiler.h" 10 #include "src/ic/ic-compiler.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 } 58 }
59 } 59 }
60 60
61 Label number_case; 61 Label number_case;
62 Label* smi_target = IncludesNumberMap(maps) ? &number_case : &miss; 62 Label* smi_target = IncludesNumberMap(maps) ? &number_case : &miss;
63 __ JumpIfSmi(receiver(), smi_target); 63 __ JumpIfSmi(receiver(), smi_target);
64 64
65 // Polymorphic keyed stores may use the map register 65 // Polymorphic keyed stores may use the map register
66 Register map_reg = scratch1(); 66 Register map_reg = scratch1();
67 DCHECK(kind() != Code::KEYED_STORE_IC || 67 DCHECK(kind() != Code::KEYED_STORE_IC ||
68 map_reg.is(ElementTransitionAndStoreDescriptor::MapRegister())); 68 map_reg.is(StoreTransitionDescriptor::MapRegister()));
69 69
70 int receiver_count = maps->length(); 70 int receiver_count = maps->length();
71 int number_of_handled_maps = 0; 71 int number_of_handled_maps = 0;
72 __ ldr(map_reg, FieldMemOperand(receiver(), HeapObject::kMapOffset)); 72 __ ldr(map_reg, FieldMemOperand(receiver(), HeapObject::kMapOffset));
73 for (int current = 0; current < receiver_count; ++current) { 73 for (int current = 0; current < receiver_count; ++current) {
74 Handle<Map> map = maps->at(current); 74 Handle<Map> map = maps->at(current);
75 if (!map->is_deprecated()) { 75 if (!map->is_deprecated()) {
76 number_of_handled_maps++; 76 number_of_handled_maps++;
77 Handle<WeakCell> cell = Map::WeakCellForMap(map); 77 Handle<WeakCell> cell = Map::WeakCellForMap(map);
78 __ CmpWeakValue(map_reg, cell, scratch2()); 78 __ CmpWeakValue(map_reg, cell, scratch2());
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 // Return the generated code. 125 // Return the generated code.
126 return GetCode(kind(), Code::NORMAL, factory()->empty_string(), POLYMORPHIC); 126 return GetCode(kind(), Code::NORMAL, factory()->empty_string(), POLYMORPHIC);
127 } 127 }
128 128
129 129
130 #undef __ 130 #undef __
131 } // namespace internal 131 } // namespace internal
132 } // namespace v8 132 } // namespace v8
133 133
134 #endif // V8_TARGET_ARCH_ARM 134 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/ic/arm/access-compiler-arm.cc ('k') | src/ic/arm64/access-compiler-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698