chrome/browser/ui/views/frame/opaque_browser_frame_view_platform_specific.h - Issue 124893002: OpaqueBrowserFrameViewPlatformSpecific::Create no longer returns NULL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view_platform_specific.h

Issue 124893002: OpaqueBrowserFrameViewPlatformSpecific::Create no longer returns NULL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove redundant DCHECKs. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/opaque_browser_frame_view.cc ('k') | chrome/browser/ui/views/frame/opaque_browser_frame_view_platform_specific.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/opaque_browser_frame_view_platform_specific.h

diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view_platform_specific.h b/chrome/browser/ui/views/frame/opaque_browser_frame_view_platform_specific.h

index 7f6b1ff21b455503923b786a0ac6eecd65e59a49..765cf706e17026fe56bd8f591c4c6c4bb418285f 100644

--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view_platform_specific.h

+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view_platform_specific.h

@@ -13,8 +13,7 @@ class OpaqueBrowserFrameViewPlatformSpecific {

public:

virtual ~OpaqueBrowserFrameViewPlatformSpecific() {}

- // Builds an observer for |view| and |layout|. This method returns NULL on

- // platforms which don't need configuration.

+ // Builds an observer for |view| and |layout|.

static OpaqueBrowserFrameViewPlatformSpecific* Create(

OpaqueBrowserFrameView* view,

OpaqueBrowserFrameViewLayout* layout);