Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view.cc

Issue 124893002: OpaqueBrowserFrameViewPlatformSpecific::Create no longer returns NULL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove redundant DCHECKs. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/opaque_browser_frame_view_platform_specific.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
index 19ad04299e523b4456ea48419dfa68b213a8b27f..f370c85a8039cadb8d6536f4986bf91686247f51 100644
--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
@@ -428,10 +428,8 @@ void OpaqueBrowserFrameView::Observe(
bool OpaqueBrowserFrameView::ShouldShowWindowIcon() const {
views::WidgetDelegate* delegate = frame()->widget_delegate();
- // ShouldShowTitleBar defaults to true.
- if (platform_observer_ && !platform_observer_->ShouldShowTitleBar())
- return false;
- return delegate && delegate->ShouldShowWindowIcon();
+ return platform_observer_->ShouldShowTitleBar() && delegate &&
+ delegate->ShouldShowWindowIcon();
}
bool OpaqueBrowserFrameView::ShouldShowWindowTitle() const {
@@ -439,10 +437,8 @@ bool OpaqueBrowserFrameView::ShouldShowWindowTitle() const {
// a window is being destroyed.
// See more discussion at http://crosbug.com/8958
views::WidgetDelegate* delegate = frame()->widget_delegate();
- // ShouldShowTitleBar defaults to true.
- if (platform_observer_ && !platform_observer_->ShouldShowTitleBar())
- return false;
- return delegate && delegate->ShouldShowWindowTitle();
+ return platform_observer_->ShouldShowTitleBar() && delegate &&
+ delegate->ShouldShowWindowTitle();
}
base::string16 OpaqueBrowserFrameView::GetWindowTitle() const {
@@ -470,8 +466,6 @@ gfx::Size OpaqueBrowserFrameView::GetBrowserViewMinimumSize() const {
bool OpaqueBrowserFrameView::ShouldShowCaptionButtons() const {
if (!OpaqueBrowserFrameViewLayout::ShouldAddDefaultCaptionButtons())
return false;
- if (!platform_observer_)
- return true;
return platform_observer_->ShouldShowCaptionButtons();
}
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/opaque_browser_frame_view_platform_specific.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698