Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1248893004: Revert of 565 support for SIMD xfermodes (Closed)

Created:
5 years, 5 months ago by mtklein
Modified:
5 years, 5 months ago
Reviewers:
msarett, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of 565 support for SIMD xfermodes (patchset #4 id:60001 of https://codereview.chromium.org/1245673002/) Reason for revert: NEON 565 gold images have gone ugly. This is what I get for writing and testing SSE and just writing NEON. E.g. colortype_xfermodes, dstreadshuffle, bigbitmaprect, pictures, textbloblooper, aaxfermodes (only Plus) Original issue's description: > 565 support for SIMD xfermodes > > This uses the most basic approach possible: > - to load an Sk4px from 565, convert to SkPMColors on the stack serially then load those SkPMColors. > - to store an Sk4px to 565, store to SkPMColors on the stack then convert to 565 serially. > > Clearly, we can optimize these loads and stores. That's a TODO. > > The code using SkPMFloat is the same idea but a little more long-term viable, as we're only operating on one pixel at a time anyway. We could probably write 565 <-> SkPMFloat methods, but I'd rather not until it's really compelling. > > The speedups are varied but similar across SSE and NEON: a few uninteresting, many 50% faster, some 2x faster, and SoftLight ~4x faster. > > This will cause minor GM diffs, but I don't think any layout test changes. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/942930dcaa51f66d82cdaf46ae62efebd16c8cd0 > > Committed: https://skia.googlesource.com/skia/+/860dcaa2ddfdadc050af4f943a84a9d499315066 TBR=msarett@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/78f55fc4bf4c1a8f7cb6395e9a30e16e5e4622a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -230 lines) Patch
M src/core/Sk4px.h View 5 chunks +6 lines, -15 lines 0 comments Download
M src/core/Sk4pxXfermode.h View 2 chunks +9 lines, -38 lines 0 comments Download
M src/opts/Sk4px_NEON.h View 1 chunk +0 lines, -71 lines 0 comments Download
M src/opts/Sk4px_SSE2.h View 1 chunk +0 lines, -75 lines 0 comments Download
M src/opts/Sk4px_none.h View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of 565 support for SIMD xfermodes
5 years, 5 months ago (2015-07-22 01:34:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248893004/1
5 years, 5 months ago (2015-07-22 01:34:36 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 01:34:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/78f55fc4bf4c1a8f7cb6395e9a30e16e5e4622a8

Powered by Google App Engine
This is Rietveld 408576698