Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1218)

Issue 1248853003: skia: GrGLAssembleGLInterface update load chromium extension functions (Closed)

Created:
5 years, 5 months ago by hendrikw
Modified:
5 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@angle_deps_roll
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skia: GrGLAssembleGLInterface update load chromium extension functions Command buffer will expose GL_CHROMIUM_framebuffer_multisample and GL_CHROMIUM_map_sub, added support for these to enable interface validation to succeed. Committed: https://skia.googlesource.com/skia/+/1ae488f78b62ace1f5a3c5b4e44deb88c338196f

Patch Set 1 #

Patch Set 2 : Replace tab with spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M src/gpu/gl/GrGLAssembleInterface.cpp View 1 1 chunk +11 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
hendrikw
PTAL, thanks!
5 years, 5 months ago (2015-07-21 19:52:43 UTC) #2
bsalomon
lgtm
5 years, 5 months ago (2015-07-21 20:07:31 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 1244843003 Patch 1). Please resolve the dependency and ...
5 years, 5 months ago (2015-07-21 20:13:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248853003/20001
5 years, 5 months ago (2015-07-22 16:17:15 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 16:30:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1ae488f78b62ace1f5a3c5b4e44deb88c338196f

Powered by Google App Engine
This is Rietveld 408576698