Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1244843003: skia: ANGLE deps roll (Closed)

Created:
5 years, 5 months ago by hendrikw
Modified:
5 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

ANGLE deps roll If we ever want to allow the command buffer as a skia gles2 backend, we need a more up to date version of ANGLE, specifically there are 4 defines that differ between newer and older versions of ANGLE which we use in skia, I've updated these in this change. I'm not quite sure if what I've done for the 'angle_path' is correct, I tried setting it to a path relative to skia, and to '<(DEPTH)', both of which do not compile correctly, only '../' worked. Committed: https://skia.googlesource.com/skia/+/db0b1e796ddbd08e6be8a666537318b1c0e2ce56 Committed: https://skia.googlesource.com/skia/+/10b371c6e376f1f3eba88ac4bfdf34652f3ab1dc

Patch Set 1 #

Patch Set 2 : even newer version of ANGLE - hopefully without compile errors. #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M gyp/common_variables.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/angle/SkANGLEGLContext.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
hendrikw
PTAL
5 years, 5 months ago (2015-07-21 18:28:03 UTC) #2
bsalomon
On 2015/07/21 18:28:03, hendrikw wrote: > PTAL lgtm if the angle bots run correctly.
5 years, 5 months ago (2015-07-21 18:30:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244843003/1
5 years, 5 months ago (2015-07-21 19:55:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/db0b1e796ddbd08e6be8a666537318b1c0e2ce56
5 years, 5 months ago (2015-07-21 20:18:29 UTC) #8
hendrikw
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1245223007/ by hendrikw@chromium.org. ...
5 years, 5 months ago (2015-07-21 20:24:12 UTC) #9
hendrikw
I happened to take the chrome's revision on an angle build that failed. Updated to ...
5 years, 5 months ago (2015-07-21 20:47:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244843003/20001
5 years, 5 months ago (2015-07-21 20:47:56 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/2069) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 5 months ago (2015-07-21 20:48:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244843003/20001
5 years, 5 months ago (2015-07-21 21:03:28 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/2173) Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 5 months ago (2015-07-21 21:03:54 UTC) #19
hendrikw
On 2015/07/21 21:03:54, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 5 months ago (2015-07-21 21:04:41 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244843003/40001
5 years, 5 months ago (2015-07-21 21:19:28 UTC) #23
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 21:50:10 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/10b371c6e376f1f3eba88ac4bfdf34652f3ab1dc

Powered by Google App Engine
This is Rietveld 408576698