Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: ui/ozone/public/client_native_pixmap_factory.h

Issue 1248713002: ozone: ClientPixmapManager passes VGEM fd from browser to renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: follow IOSurface pattern. remove wrapper classes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/ozone/public/client_native_pixmap_factory.h
diff --git a/ui/ozone/public/client_native_pixmap_factory.h b/ui/ozone/public/client_native_pixmap_factory.h
index a5d58e16c6e1018e20e628094165d076c9478211..9ca0e6e0fe493110c26e83e827e392b93bfbe8a2 100644
--- a/ui/ozone/public/client_native_pixmap_factory.h
+++ b/ui/ozone/public/client_native_pixmap_factory.h
@@ -7,6 +7,7 @@
#include <vector>
+#include "base/file_descriptor_posix.h"
#include "base/memory/scoped_ptr.h"
#include "ui/gfx/buffer_types.h"
#include "ui/ozone/ozone_export.h"
@@ -17,12 +18,6 @@ struct NativePixmapHandle;
class Size;
}
-namespace base {
-
-struct FileDescriptor;
-
-} // namespace base
-
namespace ui {
// The Ozone interface allows external implementations to hook into Chromium to
@@ -36,6 +31,12 @@ class OZONE_EXPORT ClientNativePixmapFactory {
virtual ~ClientNativePixmapFactory();
+ // Open VGEM device file. A caller takes ownership of the file descriptor.
+ virtual int OpenVgemFD() const = 0;
reveman 2015/08/14 13:19:13 could this return a ScopedFD to make the ownership
dshwang 2015/08/14 16:20:27 Done.
+
+ // Set VGEM device file. This takes ownership of the file descriptor.
+ virtual void SetVgemFD(const base::FileDescriptor& vgem_fd) = 0;
reveman 2015/08/14 13:19:13 Can we pass a ScopedFD to this function instead?
dshwang 2015/08/14 16:20:27 Done.
+
struct Configuration {
gfx::BufferFormat format;
gfx::BufferUsage usage;

Powered by Google App Engine
This is Rietveld 408576698