ozone: ClientPixmapManager passes VGEM fd from browser to renderer.

ui/ozone/public/client_native_pixmap_factory.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_OZONE_PUBLIC_CLIENT_NATIVE_PIXMAP_FACTORY_H_
 #define UI_OZONE_PUBLIC_CLIENT_NATIVE_PIXMAP_FACTORY_H_
 
 #include <vector>
 
+#include "base/file_descriptor_posix.h"
 #include "base/memory/scoped_ptr.h"
 #include "ui/gfx/buffer_types.h"
 #include "ui/ozone/ozone_export.h"
 #include "ui/ozone/public/client_native_pixmap.h"
 
 namespace gfx {
 struct NativePixmapHandle;
 class Size;
 }
 
-namespace base {
-
-struct FileDescriptor;
-
-}  // namespace base
-
 namespace ui {
 
 // The Ozone interface allows external implementations to hook into Chromium to
 // provide a client pixmap for non-GPU processes.
 class OZONE_EXPORT ClientNativePixmapFactory {
  public:
   static ClientNativePixmapFactory* GetInstance();
   static void SetInstance(ClientNativePixmapFactory* instance);
 
   static scoped_ptr<ClientNativePixmapFactory> Create();
 
   virtual ~ClientNativePixmapFactory();
 
+  // Open VGEM device file. A caller takes ownership of the file descriptor.
+  virtual int OpenVgemFD() const = 0;

[reveman, 2015/08/14 13:19:13]

could this return a ScopedFD to make the ownership more clear?

[dshwang, 2015/08/14 16:20:27]

Done.

+
+  // Set VGEM device file. This takes ownership of the file descriptor.
+  virtual void SetVgemFD(const base::FileDescriptor& vgem_fd) = 0;

[reveman, 2015/08/14 13:19:13]

Can we pass a ScopedFD to this function instead?

[dshwang, 2015/08/14 16:20:27]

Done.

+
   struct Configuration {
     gfx::BufferFormat format;
     gfx::BufferUsage usage;
   };
 
   // Gets supported format/usage configurations.
   virtual std::vector<Configuration> GetSupportedConfigurations() const = 0;
 
   // TODO(dshwang): implement it. crbug.com/475633
   // Import the native pixmap from |handle| to be used in non-GPU processes.
   // This function takes ownership of any file descriptors in |handle|.
   virtual scoped_ptr<ClientNativePixmap> ImportFromHandle(
       const gfx::NativePixmapHandle& handle,
       const gfx::Size& size,
       gfx::BufferUsage usage) = 0;
 
  protected:
   ClientNativePixmapFactory();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ClientNativePixmapFactory);
 };
 
 }  // namespace ui
 
 #endif  // UI_OZONE_PUBLIC_CLIENT_NATIVE_PIXMAP_FACTORY_H_