Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1248443003: Move Full-codegen into its own folder. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move Full-codegen into its own folder. R=jkummerow@chromium.org Committed: https://crrev.com/3be39a24bf63cf7d87d45ea2e0f986707154a089 Cr-Commit-Position: refs/heads/master@{#29840}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix OWNERS #

Patch Set 3 : rename define #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -46035 lines) Patch
M BUILD.gn View 1 2 13 chunks +8 lines, -8 lines 0 comments Download
M src/arm/builtins-arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm/deoptimizer-arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D src/arm/full-codegen-arm.cc View 1 2 1 chunk +0 lines, -5478 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/deoptimizer-arm64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D src/arm64/full-codegen-arm64.cc View 1 2 1 chunk +0 lines, -5462 lines 0 comments Download
M src/compiler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-inlining.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/frames.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D src/full-codegen.h View 1 2 1 chunk +0 lines, -1089 lines 0 comments Download
D src/full-codegen.cc View 1 2 1 chunk +0 lines, -1595 lines 0 comments Download
A src/full-codegen/OWNERS View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A + src/full-codegen/arm/full-codegen-arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + src/full-codegen/full-codegen.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + src/full-codegen/full-codegen.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + src/full-codegen/mips/full-codegen-mips.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + src/full-codegen/x64/full-codegen-x64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + src/full-codegen/x87/full-codegen-x87.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D src/ia32/full-codegen-ia32.cc View 1 2 1 chunk +0 lines, -5346 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/mips/deoptimizer-mips.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D src/mips/full-codegen-mips.cc View 1 2 1 chunk +0 lines, -5435 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/deoptimizer-mips64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D src/mips64/full-codegen-mips64.cc View 1 2 1 chunk +0 lines, -5440 lines 0 comments Download
M src/objects.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/optimizing-compile-dispatcher.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/builtins-ppc.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/deoptimizer-ppc.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D src/ppc/full-codegen-ppc.cc View 1 2 1 chunk +0 lines, -5426 lines 0 comments Download
M src/runtime-profiler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-compiler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/snapshot/snapshot-common.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/x64/builtins-x64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D src/x64/full-codegen-x64.cc View 1 2 1 chunk +0 lines, -5365 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/x87/deoptimizer-x87.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D src/x87/full-codegen-x87.cc View 1 2 1 chunk +0 lines, -5337 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-mark-compact.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 2 17 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Yang
5 years, 5 months ago (2015-07-23 12:28:53 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1248443003/1
5 years, 5 months ago (2015-07-23 12:29:05 UTC) #3
rmcilroy
https://codereview.chromium.org/1248443003/diff/1/src/full-codegen/OWNERS File src/full-codegen/OWNERS (right): https://codereview.chromium.org/1248443003/diff/1/src/full-codegen/OWNERS#newcode1 src/full-codegen/OWNERS:1: jkummerow@chromium.orgi you've got an added 'i' at the end ...
5 years, 5 months ago (2015-07-23 12:36:02 UTC) #5
Jakob Kummerow
LGTM https://codereview.chromium.org/1248443003/diff/1/src/full-codegen/full-codegen.h File src/full-codegen/full-codegen.h (right): https://codereview.chromium.org/1248443003/diff/1/src/full-codegen/full-codegen.h#newcode5 src/full-codegen/full-codegen.h:5: #ifndef V8_FULL_CODEGEN_H_ nit: strictly speaking this needs updating ...
5 years, 5 months ago (2015-07-23 12:45:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248443003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1248443003/20001
5 years, 5 months ago (2015-07-24 06:47:26 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248443003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1248443003/20001
5 years, 5 months ago (2015-07-24 09:28:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248443003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1248443003/20001
5 years, 5 months ago (2015-07-24 09:52:41 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:20001)
5 years, 5 months ago (2015-07-24 10:11:51 UTC) #16
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 10:12:20 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3be39a24bf63cf7d87d45ea2e0f986707154a089
Cr-Commit-Position: refs/heads/master@{#29840}

Powered by Google App Engine
This is Rietveld 408576698