Issue 1248363003: Merge M45: Remove NPAPI command line flags entirely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1248363003: Merge M45: Remove NPAPI command line flags entirely. (Closed)

Created:
5 years, 5 months ago by Will Harris

Modified:
5 years, 5 months ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2454

Target Ref:
refs/pending/branch-heads/2454

Project:
chromium

Visibility:
Public.

More Reviews

Description

Merge M45: Remove NPAPI command line flags entirely. ContentShell now overrides IsNpapiEnabled() to enable NPAPI for testing. BUG=493212 CQ_INCLUDE_TRYBOTS=tryserver.blink:win_blink_rel,mac_blink_rel Review URL: https://codereview.chromium.org/1240543003 Cr-Commit-Position: refs/heads/master@{#339469} (cherry picked from commit 6be0628ff61f6ffd12d686caddb8c522e10824a9) Committed: https://chromium.googlesource.com/chromium/src/+/1ad0887897e3055a696379f1a8fb417be7623ae6

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -605 lines)			Patch
D	content/browser/plugin_browsertest.cc	View	1 chunk	+0 lines, -579 lines	0 comments	Download
M	content/browser/plugin_service_impl.cc	View	2 chunks	+11 lines, -18 lines	0 comments	Download
M	content/public/browser/content_browser_client.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/public/browser/content_browser_client.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/public/common/content_switches.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/public/common/content_switches.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/shell/app/shell_main_delegate.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/shell/browser/shell_content_browser_client.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/shell/browser/shell_content_browser_client.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Will Harris

5 years, 5 months ago (2015-07-23 20:31:09 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1ad0887897e3055a696379f1a8fb417be7623ae6.

Expand Messages | Collapse Messages