Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 1240543003: Remove NPAPI command line flags entirely. (Closed)

Created:
5 years, 5 months ago by Will Harris
Modified:
5 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NPAPI command line flags entirely. ContentShell now overrides IsNpapiEnabled() to enable NPAPI for testing. BUG=493212 CQ_INCLUDE_TRYBOTS=tryserver.blink:win_blink_rel,mac_blink_rel Committed: https://crrev.com/6be0628ff61f6ffd12d686caddb8c522e10824a9 Cr-Commit-Position: refs/heads/master@{#339469}

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -605 lines) Patch
D content/browser/plugin_browsertest.cc View 1 chunk +0 lines, -579 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 1 2 chunks +11 lines, -18 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Will Harris
PTAL. We want to avoid any command line override being present in M45...
5 years, 5 months ago (2015-07-18 04:01:58 UTC) #2
jam
lgtm https://codereview.chromium.org/1240543003/diff/1/content/browser/plugin_service_impl.cc File content/browser/plugin_service_impl.cc (right): https://codereview.chromium.org/1240543003/diff/1/content/browser/plugin_service_impl.cc#newcode799 content/browser/plugin_service_impl.cc:799: content::GetContentClient()->browser()->IsNPAPIEnabled(); nit: no content::
5 years, 5 months ago (2015-07-20 16:36:22 UTC) #3
Will Harris
thanks for the review. https://codereview.chromium.org/1240543003/diff/1/content/browser/plugin_service_impl.cc File content/browser/plugin_service_impl.cc (right): https://codereview.chromium.org/1240543003/diff/1/content/browser/plugin_service_impl.cc#newcode799 content/browser/plugin_service_impl.cc:799: content::GetContentClient()->browser()->IsNPAPIEnabled(); On 2015/07/20 16:36:22, jam ...
5 years, 5 months ago (2015-07-20 16:54:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240543003/20001
5 years, 5 months ago (2015-07-20 16:55:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-20 18:04:10 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 18:06:03 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6be0628ff61f6ffd12d686caddb8c522e10824a9
Cr-Commit-Position: refs/heads/master@{#339469}

Powered by Google App Engine
This is Rietveld 408576698