src/ia32/macro-assembler-ia32.cc - Issue 1248303002: Unify runtime-style IC functions with Runtime intrinsics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.cc

Issue 1248303002: Unify runtime-style IC functions with Runtime intrinsics (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Review feedback Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/macro-assembler-ia32.cc

diff --git a/src/ia32/macro-assembler-ia32.cc b/src/ia32/macro-assembler-ia32.cc

index 32b1f77bbb9964f57793a550b1930b739b5167d1..4648c5f7ae6fc1af91583a498d9b4dac9321ce13 100644

--- a/src/ia32/macro-assembler-ia32.cc

+++ b/src/ia32/macro-assembler-ia32.cc

@@ -572,7 +572,8 @@ void MacroAssembler::RecordWrite(

void MacroAssembler::DebugBreak() {

Move(eax, Immediate(0));

- mov(ebx, Immediate(ExternalReference(Runtime::kDebugBreak, isolate())));

+ mov(ebx, Immediate(ExternalReference(Runtime::kHandleDebuggerStatement,

+ isolate())));

CEntryStub ces(isolate(), 1);

call(ces.GetCode(), RelocInfo::DEBUGGER_STATEMENT);

}