src/ia32/debug-ia32.cc - Issue 1248303002: Unify runtime-style IC functions with Runtime intrinsics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/debug-ia32.cc

Issue 1248303002: Unify runtime-style IC functions with Runtime intrinsics (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Review feedback Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/debug-ia32.cc

diff --git a/src/ia32/debug-ia32.cc b/src/ia32/debug-ia32.cc

index 47ecc87875b0a99fbe3e8d4ba46f07a6d6904426..345ad3da8b85d9e251f7643246bfe86208d4f169 100644

--- a/src/ia32/debug-ia32.cc

+++ b/src/ia32/debug-ia32.cc

@@ -70,7 +70,9 @@ void DebugCodegen::GenerateDebugBreakStub(MacroAssembler* masm,

if (mode == SAVE_RESULT_REGISTER) __ push(eax);

__ Move(eax, Immediate(0)); // No arguments.

- __ mov(ebx, Immediate(ExternalReference::debug_break(masm->isolate())));

+ __ mov(ebx,

+ Immediate(ExternalReference(

+ Runtime::FunctionForId(Runtime::kDebugBreak), masm->isolate())));

CEntryStub ceb(masm->isolate(), 1);

__ CallStub(&ceb);