Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 12483002: browser plugin: Get the offscreen shared context from RenderThreadImpl (Closed)

Created:
7 years, 9 months ago by danakj
Modified:
7 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, backer, piman, jamesr
Visibility:
Public.

Description

browser plugin: Get the offscreen shared context from RenderThreadImpl Stop using WebSharedGraphicsContext3D since it is going away. Get the shared context from the ContextProvider on RenderThreadImpl. TEST=load poster circle in browser plugin "browser" demo then hit back button. BUG=177739 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M content/renderer/browser_plugin/browser_plugin_compositing_helper.cc View 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
danakj
7 years, 9 months ago (2013-03-05 21:28:50 UTC) #1
danakj
This depends on https://codereview.chromium.org/12212100/
7 years, 9 months ago (2013-03-05 21:29:01 UTC) #2
alexst (slow to review)
lgtm
7 years, 9 months ago (2013-03-05 21:38:41 UTC) #3
Fady Samuel
rubberstamp LGTM
7 years, 9 months ago (2013-03-05 21:39:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12483002/1
7 years, 9 months ago (2013-03-06 16:01:38 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-06 17:54:35 UTC) #6
Message was sent while issue was closed.
Change committed as 186460

Powered by Google App Engine
This is Rietveld 408576698