Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: tools/gn/command_gyp.cc

Issue 124803002: Make use of ElapsedTimer API for the 'gen' command. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update command_gyp as well Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/command_gen.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_gyp.cc
diff --git a/tools/gn/command_gyp.cc b/tools/gn/command_gyp.cc
index 9178d159eff69119490536c7ecf84b7d3280ae2e..02ea51c154a1382d90ffbcbde45eecabe5e16768 100644
--- a/tools/gn/command_gyp.cc
+++ b/tools/gn/command_gyp.cc
@@ -10,7 +10,7 @@
#include "base/command_line.h"
#include "base/environment.h"
#include "base/strings/string_number_conversions.h"
-#include "base/time/time.h"
+#include "base/timer/elapsed_timer.h"
#include "tools/gn/build_settings.h"
#include "tools/gn/commands.h"
#include "tools/gn/err.h"
@@ -326,9 +326,7 @@ const char kGyp_Help[] =
" }\n";
int RunGyp(const std::vector<std::string>& args) {
- const CommandLine* cmdline = CommandLine::ForCurrentProcess();
-
- base::TimeTicks begin_time = base::TimeTicks::Now();
+ base::ElapsedTimer timer;
// Deliberately leaked to avoid expensive process teardown.
Setup* setup_debug = new Setup;
@@ -407,9 +405,9 @@ int RunGyp(const std::vector<std::string>& args) {
return 1;
}
- // Timing info.
- base::TimeTicks end_time = base::TimeTicks::Now();
- if (!cmdline->HasSwitch(kSwitchQuiet)) {
+ base::TimeDelta elapsed_time = timer.Elapsed();
+
+ if (!CommandLine::ForCurrentProcess()->HasSwitch(kSwitchQuiet)) {
OutputString("Done. ", DECORATION_GREEN);
std::string stats = "Wrote " +
@@ -418,7 +416,7 @@ int RunGyp(const std::vector<std::string>& args) {
base::IntToString(
setup_debug->scheduler().input_file_manager()->GetInputFileCount())
+ " GN files in " +
- base::IntToString((end_time - begin_time).InMilliseconds()) + "ms\n";
+ base::IntToString(elapsed_time.InMilliseconds()) + "ms\n";
OutputString(stats);
}
« no previous file with comments | « tools/gn/command_gen.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698