Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: tools/gn/command_gen.cc

Issue 124803002: Make use of ElapsedTimer API for the 'gen' command. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update command_gyp as well Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/command_gyp.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_gen.cc
diff --git a/tools/gn/command_gen.cc b/tools/gn/command_gen.cc
index cde677a1443d01191210272d667f171a1f529177..f4fefcc5c925e56975722dcf32f0752f4ba13838 100644
--- a/tools/gn/command_gen.cc
+++ b/tools/gn/command_gen.cc
@@ -6,7 +6,7 @@
#include "base/bind.h"
#include "base/command_line.h"
#include "base/strings/string_number_conversions.h"
-#include "base/time/time.h"
+#include "base/timer/elapsed_timer.h"
#include "tools/gn/build_settings.h"
#include "tools/gn/commands.h"
#include "tools/gn/ninja_target_writer.h"
@@ -57,7 +57,7 @@ const char kGen_Help[] =
// Note: partially duplicated in command_gyp.cc.
int RunGen(const std::vector<std::string>& args) {
- base::TimeTicks begin_time = base::TimeTicks::Now();
+ base::ElapsedTimer timer;
// Deliberately leaked to avoid expensive process teardown.
Setup* setup = new Setup;
@@ -80,7 +80,7 @@ int RunGen(const std::vector<std::string>& args) {
setup->builder()))
return 1;
- base::TimeTicks end_time = base::TimeTicks::Now();
+ base::TimeDelta elapsed_time = timer.Elapsed();
if (!CommandLine::ForCurrentProcess()->HasSwitch(kSwitchQuiet)) {
OutputString("Done. ", DECORATION_GREEN);
@@ -91,7 +91,7 @@ int RunGen(const std::vector<std::string>& args) {
base::IntToString(
setup->scheduler().input_file_manager()->GetInputFileCount()) +
" files in " +
- base::IntToString((end_time - begin_time).InMilliseconds()) + "ms\n";
+ base::IntToString(elapsed_time.InMilliseconds()) + "ms\n";
OutputString(stats);
}
« no previous file with comments | « no previous file | tools/gn/command_gyp.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698