Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 124803002: Make use of ElapsedTimer API for the 'gen' command. (Closed)

Created:
6 years, 11 months ago by tfarina
Modified:
6 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Make use of ElapsedTimer API for the 'gen' command. BUG=None TEST=run ./out/Default/gn, it should reporte the elapsed time without no regressions. R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243888

Patch Set 1 #

Patch Set 2 : update command_gyp as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M tools/gn/command_gen.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/gn/command_gyp.cc View 1 4 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
6 years, 11 months ago (2014-01-05 23:55:16 UTC) #1
brettw
command_gyp.cc has almost the same code. Want to change that too? LGTM with that.
6 years, 11 months ago (2014-01-08 05:21:43 UTC) #2
tfarina
On 2014/01/08 05:21:43, brettw wrote: > command_gyp.cc has almost the same code. Want to change ...
6 years, 11 months ago (2014-01-09 01:12:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/124803002/100001
6 years, 11 months ago (2014-01-09 01:13:32 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=243881
6 years, 11 months ago (2014-01-09 04:45:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/124803002/100001
6 years, 11 months ago (2014-01-09 12:51:10 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 14:10:11 UTC) #7
Message was sent while issue was closed.
Change committed as 243888

Powered by Google App Engine
This is Rietveld 408576698