Return Windows error code when create-process fails.

chrome/installer/mini_installer/configuration.h

Index: chrome/installer/mini_installer/configuration.h
diff --git a/chrome/installer/mini_installer/configuration.h b/chrome/installer/mini_installer/configuration.h
index 1c75960d693acafad61d44912c92b87c36d81067..7aeffd5b7920d492c37efc5085abb56ba40d7560 100644
--- a/chrome/installer/mini_installer/configuration.h
+++ b/chrome/installer/mini_installer/configuration.h
@@ -7,6 +7,8 @@
 
 #include <windows.h>
 
+#include "chrome/installer/mini_installer/mini_string.h"
+
 namespace mini_installer {
 
 // A simple container of the mini_installer's configuration, as dictated by the
@@ -42,6 +44,8 @@ class Configuration {
   // line makes this the canary's app guid.
   const wchar_t* chrome_app_guid() const { return chrome_app_guid_; }
 
+  // Returns the app guid used in as the registry key.

[robertshield, 2015/08/04 03:11:36]

Stale comment?

+
   // Returns true if --chrome is explicitly or implicitly on the command line.
   bool has_chrome() const { return has_chrome_; }
 
@@ -73,9 +77,19 @@ class Configuration {
   bool is_system_level_;
   const wchar_t* previous_version_;
 
+ protected:
+  typedef StackString<128> ValueString;
+
+  // Abstract registry access for testing purposes.

[robertshield, 2015/08/04 03:11:36]

Nit: Slightly ambiguous use of the word "abstract" and this isn't a pure
virtual. I've commonly seen the comment "Virtual for testing" used elsewhere in
the codebase.

[bcwhite, 2015/08/04 19:34:30]

Done.

+  virtual bool ReadClientStateRegistryValue(
+      const HKEY root_key, const wchar_t* app_guid,
+      LONG* retval, ValueString& value);
+
  private:
   Configuration(const Configuration&);
   Configuration& operator=(const Configuration&);
+
+  void SetChromeAppGuid();
 };
 
 }  // namespace mini_installer