Return Windows error code when create-process fails.

chrome/installer/mini_installer/configuration.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_INSTALLER_MINI_INSTALLER_CONFIGURATION_H_
 #define CHROME_INSTALLER_MINI_INSTALLER_CONFIGURATION_H_
 
 #include <windows.h>
 
+#include "chrome/installer/mini_installer/mini_string.h"
+
 namespace mini_installer {
 
 // A simple container of the mini_installer's configuration, as dictated by the
 // command line used to invoke it.
 class Configuration {
  public:
   enum Operation {
     INSTALL_PRODUCT,
     CLEANUP,
   };
@@ skipping 15 matching lines @@
   // the program itself.
   int argument_count() const { return argument_count_; }
 
   // Returns the original command line.
   const wchar_t* command_line() const { return command_line_; }
 
   // Returns the app guid to be used for Chrome.  --chrome-sxs on the command
   // line makes this the canary's app guid.
   const wchar_t* chrome_app_guid() const { return chrome_app_guid_; }
 
+  // Returns the app guid used in as the registry key.

[robertshield, 2015/08/04 03:11:36]

Stale comment?

+
   // Returns true if --chrome is explicitly or implicitly on the command line.
   bool has_chrome() const { return has_chrome_; }
 
   // Returns true if --chrome-frame is on the command line.
   bool has_chrome_frame() const { return has_chrome_frame_; }
 
   // Returns true if --multi-install is on the command line.
   bool is_multi_install() const { return is_multi_install_; }
 
   // Returns true if --system-level is on the command line.
@@ skipping 11 matching lines @@
   const wchar_t* chrome_app_guid_;
   const wchar_t* command_line_;
   int argument_count_;
   Operation operation_;
   bool has_chrome_;
   bool has_chrome_frame_;
   bool is_multi_install_;
   bool is_system_level_;
   const wchar_t* previous_version_;
 
+ protected:
+  typedef StackString<128> ValueString;
+
+  // Abstract registry access for testing purposes.

[robertshield, 2015/08/04 03:11:36]

Nit: Slightly ambiguous use of the word "abstract" and this isn't a pure
virtual. I've commonly seen the comment "Virtual for testing" used elsewhere in
the codebase.

[bcwhite, 2015/08/04 19:34:30]

Done.

+  virtual bool ReadClientStateRegistryValue(
+      const HKEY root_key, const wchar_t* app_guid,
+      LONG* retval, ValueString& value);
+
  private:
   Configuration(const Configuration&);
   Configuration& operator=(const Configuration&);
+
+  void SetChromeAppGuid();
 };
 
 }  // namespace mini_installer
 
 #endif  // CHROME_INSTALLER_MINI_INSTALLER_CONFIGURATION_H_